Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async get room sid (Protocol v12). #446

Merged
merged 8 commits into from
Jan 10, 2024
Merged

async get room sid (Protocol v12). #446

merged 8 commits into from
Jan 10, 2024

Conversation

cloudwebrtc
Copy link
Contributor

No description provided.

@cloudwebrtc cloudwebrtc added the v2 label Jan 8, 2024
@cloudwebrtc cloudwebrtc changed the title async get room sid. async get room sid (Protocol v12). Jan 8, 2024
@cloudwebrtc cloudwebrtc marked this pull request as ready for review January 8, 2024 06:30
davidzhao
davidzhao approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cloudwebrtc cloudwebrtc merged commit 6a0c2db into main Jan 10, 2024
8 checks passed
@cloudwebrtc cloudwebrtc deleted the v2/async-room-id branch January 10, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @davidzhao