Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/some bugs reported by users #441

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Fix/some bugs reported by users #441

merged 5 commits into from
Dec 28, 2023

Conversation

cloudwebrtc
Copy link
Contributor

No description provided.

@cloudwebrtc cloudwebrtc marked this pull request as ready for review December 26, 2023 03:53
@cloudwebrtc cloudwebrtc changed the title Fix/some bugs from user Fix/some bugs reported from user Dec 26, 2023
@cloudwebrtc cloudwebrtc changed the title Fix/some bugs reported from user Fix/some bugs reported by users Dec 26, 2023
davidzhao
davidzhao reviewed Dec 27, 2023
View reviewed changes
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only understood parts of it. could you clarify/link to the bugs that this PR is fixing?

lib/src/core/engine.dart Show resolved Hide resolved
lib/src/widgets/video_track_renderer.dart Outdated Show resolved Hide resolved
lib/src/widgets/video_track_renderer.dart Outdated Show resolved Hide resolved
@cloudwebrtc cloudwebrtc merged commit 1015b57 into main Dec 28, 2023
7 checks passed
@cloudwebrtc cloudwebrtc deleted the fix/some-bugs-from-user branch December 28, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzhao davidzhao davidzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @davidzhao