Cleans up macro code, fixes example usage, fixes minor typos and adds linting to comply with official PEP-8 standards #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd spaces Signed-off-by: Brandon Smith <[email protected]>
This commit resolves the formatting issues in my previous pull request, fixes minor typos, and fixes the example usage which was missing the python command. Signed-off-by: Brandon Smith <[email protected]>
# Conflicts: # PyPS3checker/checker_py3.py - Improves code readability using official python PEP-8 standards - Fixes minor typos - Fixes usage example by adding the python command Signed-off-by: Brandon Smith <[email protected]>
Standardizing format with the official python linting standards increases the ease and likelihood of additional contributions from the community Signed-off-by: Brandon Smith <[email protected]>
|
Oops, forgot to add links to additional PEP-8 resources: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to fixing the minor bugs, I had already fixed the formatting issues from my previous pull request and cleaned up the implementation.
In addition to these changes, I also used linting tools to make checker_3.py PEP-8 compliant, which is the official Python 3 formatting standard defined by Guido van Rossum himself. Although it was unsolicited, implementing this standard helps make it both easier to and more likely that others will contribute!
Note: make sure the screen has sufficient width when comparing the utility title macro/release version banner and the notice/disclaimer banner that displays upon successful scans.