Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handling of _SpecialForm objects in repr_type in 3.8. #39

Merged
merged 2 commits into from
Sep 27, 2024
Merged

fix: Handling of _SpecialForm objects in repr_type in 3.8. #39

merged 2 commits into from
Sep 27, 2024

Conversation

DanCardin
Copy link
Collaborator

Notably

  • Literal is stupid in 3.8
  • typing_extensions.Literal is a different object under 3.10
  • Any (at least in 3.8) is a _SpecialForm that's not a type, so it ends up not working with the prior impl.

@DanCardin DanCardin force-pushed the dc/py38-repr_type branch 2 times, most recently from f0f9390 to 7b59427 Compare September 27, 2024 15:56
cofin
cofin approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@cofin cofin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanCardin DanCardin merged commit e2df15d into main Sep 27, 2024
12 checks passed
@DanCardin DanCardin deleted the dc/py38-repr_type branch September 27, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofin cofin cofin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanCardin @cofin