Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where :scrollable target elements never got scrolled to. #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −5
Open

fixed bug where :scrollable target elements never got scrolled to. #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f41728
updated demo to expose the fact that :scollable elements never get sc…
maranomynet Jan 30, 2012
789f0c4
fixed bug where :scrollable target elements never got scrolled to.
maranomynet Jan 30, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions demo.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@
</style>
</head>
<body>
<a href="#" class="last">Scroll slowly to last paragraph</a>
<p class="first">
<a href="#" class="last">Scroll slowly to last paragraph</a>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Mauris dignissim elit eu neque ultrices nec convallis dui lacinia. Sed ultricies pellentesque fermentum. Quisque erat felis, sagittis fringilla auctor eget, vulputate posuere sem. Donec fermentum mauris eget nunc vehicula gravida. Pellentesque orci nunc, malesuada quis imperdiet nec, tincidunt non dui. Vestibulum iaculis varius risus, in blandit libero dignissim in. Maecenas eros quam, volutpat vel faucibus sit amet, accumsan at nulla. Praesent massa metus, malesuada vitae sodales dapibus, commodo in nunc. Nullam lacinia mollis aliquet. Donec nunc lorem, luctus in dictum vel, tempus sed eros. Phasellus lobortis tincidunt ultrices. Mauris fringilla lacinia massa, vitae lobortis lorem accumsan vel. Suspendisse scelerisque justo dolor. Etiam rhoncus, justo eget consectetur placerat, nisl dui egestas enim, ut consectetur dui tellus sit amet orci. Proin non dolor velit, mollis dictum urna. Aliquam erat volutpat. Nullam tempus tempor viverra. Donec ac arcu mauris. Etiam commodo elit quis mauris egestas eleifend at eget lorem.
</p>
<p>
Expand Down Expand Up @@ -145,9 +145,14 @@
<p>
Curabitur eget justo diam. Vivamus elementum tellus ac erat tristique pharetra. Curabitur a elit sed urna bibendum pretium. Nullam sit amet magna sapien, id volutpat nulla. Nam ornare elementum turpis id lacinia. Phasellus mattis nisi quis libero volutpat non ullamcorper risus congue. Donec id nunc mi. Cum sociis natoque penatibus et magnis dis parturient montes, nascetur ridiculus mus. Proin tempor turpis in dolor pellentesque quis ultricies tellus consectetur. Sed sed velit at neque luctus fermentum. Donec eu enim sem, at malesuada quam. In erat justo, placerat ut sollicitudin sed, dictum vel justo.
</p>
<p class="last">
<p class="last" style="overflow:scroll;height:5em;">
<a href="#" class="first">Scroll normally to first paragraph</a>
Nam lacinia, risus ac hendrerit tincidunt, orci felis congue turpis, eu gravida eros nulla sed dui. Duis ante risus, semper sed malesuada sit amet, dignissim id libero. Nunc volutpat, lorem sit amet tempor ornare, nunc tellus faucibus eros, sed consequat ipsum felis vitae lacus. Aenean mattis, elit consequat ultricies rutrum, libero purus accumsan ipsum, at rhoncus mauris magna condimentum dolor. Fusce fringilla, magna vel venenatis ullamcorper, ante lacus malesuada augue, id sollicitudin arcu nisl id justo. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia Curae; Aliquam luctus nisl non tortor vehicula sit amet suscipit nibh egestas. Aliquam aliquam aliquam venenatis. Aenean eget consequat metus. Cras vel velit quam. Nullam sit amet augue dolor. Etiam in turpis at leo ultrices auctor id ut lectus. Donec consectetur ante a lacus lobortis eu sodales est ultrices. Pellentesque quis elit velit.
<br />...
<br />...
<br />...
<br />...
<br />...
</p>
<a href="#" class="first">Scroll normally to first paragraph</a>
</body>
</html>
2 changes: 1 addition & 1 deletion jquery.scrollintoview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
if (options.direction.y === true) dirStr = dirStr ? "both" : "vertical";

var el = this.eq(0);
var scroller = el.closest(":scrollable(" + dirStr + ")");
var scroller = el.parent().closest(":scrollable(" + dirStr + ")");

// check if there's anything to scroll in the first place
if (scroller.length > 0)
Expand Down
3 changes: 2 additions & 1 deletion jquery.scrollintoview.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.