-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add writer tool #542
Open
ohdearquant
wants to merge
20
commits into
main
Choose a base branch
from
add-writer-tool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add writer tool #542
+5,425
−1,306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-writer-tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Overview
This pull request introduces a new WriterTool, expanding LionAGI’s ability to handle file writing and saving. The WriterTool enforces a configurable root directory for all disk operations, preventing undesired file access outside the allowed path. It supports creating, opening, writing, and closing documents in memory, as well as saving text or chunk data to disk.
Key Changes
WriterTool
class and associated Pydantic models (WriterRequest
,WriterResponse
) for in-memory writing.allowed_root
directory, ensuring safe I/O operations.docs/modules/tools.rst
.0.8.6
to0.8.7
to reflect the new tool.Why This PR?
How to Test
allowed_root
path.open
to create or open a document.write
to append or overwrite content.list_docs
,close
docs, andsave_file
/save_chunks
within the allowed directory.Issue Reference