nightly-bcf516b8-ls97
Pre-releaseCI Report:
https://ci-tests.linuxserver.io/linuxserver/beets/nightly-bcf516b8-ls97/index.html
LinuxServer Changes:
Pin beetcamp to 0.19.2 until upstream requirements fixed.
Remote Changes:
Properly type db on the model, sort out generic types issues (#5545)
Thanks to @wisp3rwind's suggestion this PR adds types to the
relationship between Model
, Database
and Library
.
Then I worked through the rest of the issues found in the edited files.
Most of this involved providing type parameters for generic types (or
defining defaults, rather 😉).
There queryparse
module had a somewhat significant issue where the
sorting construction logic only expected to receive FieldSort
subclasses, while SmartArtistSort
was not one. Thus SmartArtistSort
has now been forced to behave and is a FieldSort
subclass. It's also
been moved to query.py
module which is where the rest of sorts are
defined.