Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5platform-plugins #43

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#251

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-251-nosync branch 4 times, most recently from 4dfa78b to 7444b72 Compare August 14, 2024 02:17
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#251
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • DWaylandInterfaceHook类中,方法setWindowRadiussetShadowRadius的返回类型从bool更改为void,但没有提供新的实现或者注释说明为什么需要这样做。
  • DNoTitlebarWlWindowHelper类中,setWindowEffectsetWindowStartUpEffect方法被添加,但是没有提供这些属性的定义和相关的信号。
  • DWaylandShellManager类中,sendProperty方法中对noTitlebar属性的处理逻辑被修改,增加了打印调试信息,但是没有改变方法的返回类型。
  • DNoTitlebarWindowHelper类中,updateWindowEffectFromPropertyupdateWindowStartUpEffectFromProperty方法被添加,但是没有提供这些属性的定义和相关的信号。

是否建议立即修改:

  • 需要提供修改的原因和上下文,以便其他开发者理解这些更改的影响。
  • 应该保持方法返回类型的一致性,避免混淆。
  • 确保添加的新方法或属性有相应的文档说明,以便其他开发者理解和使用。

@18202781743 18202781743 merged commit d817df1 into master Aug 14, 2024
28 of 31 checks passed
@18202781743 18202781743 deleted the sync-pr-251-nosync branch August 14, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants