Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5integration #58

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#251

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#251
@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • createUnresolveFont 函数中使用了 static 变量 sysFontfixedFont,但没有在函数外部初始化这些变量,可能会导致未定义行为。
  • createUnresolveFont 函数中的 setResolveMask 调用可能需要检查 font 是否为 nullptr,以避免潜在的空指针解引用。
  • font 函数中,sysFontfixedFont 的初始化逻辑重复,可以考虑提取公共代码。
  • font 函数中的 break 语句被替换为返回默认字体,这可能会改变原有的逻辑,需要确认这是否是预期的行为。

是否建议立即修改:

@kegechen kegechen merged commit 114e7fa into master Dec 3, 2024
27 of 31 checks passed
@kegechen kegechen deleted the sync-pr-251-nosync branch December 3, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants