Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: from linuxdeepin/qt5integration #39

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

deepin-ci-robot
Copy link
Contributor

Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231

@deepin-ci-robot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 10, 2024

TAG Bot

New tag: 6.0.18
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #37

@deepin-ci-robot deepin-ci-robot force-pushed the sync-pr-231-nosync branch 2 times, most recently from 54e20ec to 8ac5f00 Compare August 9, 2024 03:54
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#231
@deepin-ci-robot
Copy link
Contributor Author

deepin pr auto review

关键摘要:

  • ChameleonMovementAnimation类中,setTargetRect方法可能会导致无限循环,如果m_currentRectm_targetRect在设置新目标区域后没有变化。
  • drawMenuItemBackground方法中,使用do { ... } while(false);可能会导致编译警告,因为编译器会提示unreachable code
  • drawMenuItemBackground方法中,动画对象animation的检查应该使用QObject::findChildQt::FindDirectChildrenOnly标志,以确保只查找直接子对象。
  • drawMenuItem方法中,使用do { ... } while(false);可能会导致编译警告,因为编译器会提示unreachable code
  • drawMenuItem方法中,useHighlightedText变量的命名应该更清晰,以反映其用途。
  • drawMenuItem方法中,painter->setOpacity(1.0 - animation->progress());可能会导致透明度为0,从而无法显示任何内容。

是否建议立即修改:

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Aug 21, 2024

TAG Bot

New tag: 6.0.19
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #47

@FeiWang1119 FeiWang1119 merged commit 6a93666 into master Sep 25, 2024
29 of 31 checks passed
@FeiWang1119 FeiWang1119 deleted the sync-pr-231-nosync branch September 25, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants