Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crashed when QBytearray reallocated #264

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

18202781743
Copy link
Contributor

Using a variable to avoid reallocating memory.

pms: BUG-292371

Using a variable to avoid reallocating memory.

pms: BUG-292371
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 代码中使用了toLocal8Bit()方法,这可能会导致在不同平台上的编码问题,建议使用toUtf8()方法以确保跨平台兼容性。
  • QString的拼接操作在循环或频繁调用的场景下可能会影响性能,建议使用QString::arg()方法来提高效率。

是否建议立即修改:

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Dec 5, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#264
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, FeiWang1119, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit bfaf20a into linuxdeepin:master Dec 5, 2024
18 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Dec 5, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#264
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants