Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app crashed for DNotitebarWindowHelper #263

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

18202781743
Copy link
Contributor

DNotitebarWindowHelper is delete by manual instead of Window
deleted, so we need to resetVtable.

pms: BUG-368399

DNotitebarWindowHelper is delete by manual instead of Window
deleted, so we need to resetVtable.

pms: BUG-368399
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在新增代码中,对VtableHook::hasVtableVtableHook::resetVtable的使用需要确保m_window对象的有效性,以避免潜在的空指针异常。
  • 检查VtableHook类的实现,确保resetVtable方法不会对窗口状态产生不良影响。

是否建议立即修改:

  • 是,需要确保代码的健壮性和安全性,避免潜在的运行时错误。

deepin-ci-robot added a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Dec 4, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#263
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, ComixHe, FeiWang1119

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FeiWang1119 FeiWang1119 merged commit 117574e into linuxdeepin:master Dec 4, 2024
16 of 20 checks passed
FeiWang1119 pushed a commit to linuxdeepin/qt6platform-plugins that referenced this pull request Dec 4, 2024
Synchronize source files from linuxdeepin/qt5platform-plugins.

Source-pull-request: linuxdeepin/qt5platform-plugins#263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants