Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menu item and slider style tweak #242

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

Whale107
Copy link
Contributor

@Whale107 Whale107 commented Sep 6, 2024

调整滑动条横条和刻度颜色

Log: 调整滑动条横条和刻度颜色
Bug: https://pms.uniontech.com/bug-view-254295.html
Influence: 调整滑动条横条和刻度颜色
为解决触摸屏上右键菜单的误触问题,需要菜单内容与边界有间隔.
为了美观,在有间隔后需要为其绘制圆角

Log: 调整菜单样式
Task: https://pms.uniontech.com/task-view-362001.html
Influence: 右键菜单(窗口右键菜单除外)
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Sep 6, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#242
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • drawMenuItemBackground函数中,新增代码中对QMenu对象的检查可能导致性能问题,特别是在大量菜单项的情况下。
  • radius变量在drawMenuItemBackground函数中被重复使用,建议定义为常量以避免潜在的错误。
  • margin变量在drawMenuItemBackground函数中被重复使用,建议定义为常量以避免潜在的错误。
  • adjustColor函数的使用未在代码更改中提供上下文,需要确认其必要性以及是否正确实现了预期的效果。
  • pixelMetric函数中PM_MenuHMargin的默认返回值从0更改为8,需要确认这一更改是否符合设计要求。

是否建议立即修改:

@Whale107 Whale107 requested a review from kegechen September 6, 2024 08:32
@kegechen kegechen changed the title two commit cherry-pick from gerrit menu item and slider style tweak Sep 6, 2024
@Whale107 Whale107 requested a review from FeiWang1119 September 6, 2024 09:11
@Whale107 Whale107 merged commit 345cf68 into linuxdeepin:master Sep 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants