Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 更改checkbox和radio实现方式为dci图标,增加动效 #235

Closed
wants to merge 4 commits into from

Conversation

Whale107
Copy link
Contributor

@Whale107 Whale107 commented Aug 5, 2024

更改checkbox和radio实现方式为dci图标,增加动效

Log:

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#235
Copy link

github-actions bot commented Aug 5, 2024

TAG Bot

TAG: 5.6.32
EXISTED: yes
DISTRIBUTION: unstable

更改checkbox和radio实现方式为dci图标,增加动效

Log:
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#235
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Aug 5, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#235
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • checkDciIconEngine函数中,dciIconPlayer的创建和连接应该在dciIconPlayers.insert之后,以确保在事件过滤器中使用的是最新的dciIconPlayer实例。
  • eventFilter函数中的if语句应该使用qobject_cast来检查watched是否为QRadioButtonQCheckBox的实例,以避免潜在的类型转换问题。
  • SPDX-FileCopyrightText的更新应该遵循项目的开源许可证要求,如果项目使用的是GPL或其他要求更详细版权信息的许可证,则需要更新版权年份。

是否建议立即修改:

@Whale107 Whale107 closed this Aug 5, 2024
@Whale107 Whale107 deleted the radio/checkbox branch August 5, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants