Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): failed when qt6xdg not found #234

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

kegechen
Copy link
Contributor

remove required xdg

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 22, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#234
@kegechen kegechen requested review from asterwyx and FeiWang1119 July 22, 2024 08:07
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 代码中的find_package命令顺序被更改,可能会影响依赖关系和库的查找。
  • 变量Qt${QT_VERSION_MAJOR}XdgIconLoader_FOUND已被替换为Qt${QT_VERSION_MAJOR}Xdg_FOUND,需要确认这一更改是否已在所有相关代码中实施。

是否建议立即修改:

  • 是,需要确保find_package命令的顺序更改不会导致依赖问题,并且确认变量名称的更改已在所有相关代码中实施。

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 22, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#234
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen kegechen merged commit f5c1ef9 into linuxdeepin:master Jul 22, 2024
15 of 16 checks passed
kegechen pushed a commit to linuxdeepin/qt6integration that referenced this pull request Jul 22, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants