Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can't set transparent for Menu's background #227

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

18202781743
Copy link
Contributor

Menu's background always fill a color even it's transparent. in somecase we need fill background by caller.

deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 3, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#227
BLumia
BLumia previously approved these changes Jul 3, 2024
Menu's background always fill a color even it's transparent.
in somecase we need fill background by caller.
deepin-ci-robot added a commit to linuxdeepin/qt6integration that referenced this pull request Jul 4, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#227
@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在新增的条件判断中,检查了color.color().alpha() != 0,这是一个好的做法,可以避免在背景色为完全透明时仍然绘制菜单项背景。

是否建议立即修改:

  • 否,当前提交的修改是合理的,没有发现需要立即修改的问题。但是,建议进行以下几点改进:
    • 确保新增的条件判断color.color().alpha() != 0的逻辑正确,并且与整体代码库的逻辑一致。
    • 如果代码库中有针对透明背景的菜单项背景绘制逻辑,确保它们不会互相冲突,并且与当前的修改协同工作。
    • 添加必要的注释,解释为什么需要检查alpha()不为0,以便其他开发者理解这一变更的背景。
    • 如果代码库中有单元测试,确保它们能够覆盖到这一更改的情况,并且测试通过。

@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, zccrs

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 91f71f8 into linuxdeepin:master Jul 4, 2024
18 of 20 checks passed
18202781743 pushed a commit to linuxdeepin/qt6integration that referenced this pull request Jul 4, 2024
Synchronize source files from linuxdeepin/qt5integration.

Source-pull-request: linuxdeepin/qt5integration#227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants