fix: qApp set fixed font not work #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegechen
commented
Oct 20, 2023
zccrs
reviewed
Nov 1, 2023
deepin-ci-robot
added a commit
to linuxdeepin/qt6integration
that referenced
this pull request
Nov 1, 2023
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#199
zccrs
approved these changes
Nov 1, 2023
zccrs
requested changes
Nov 1, 2023
onFontChanged will send ApplicationFontChange event to all windows. we stop this opration if qApp set a font sub menu ==> draw arrow icon ==> QIcon::fromtheme ==> QIconLoader ==> themeHint(SystemIconThemeName) ==> appTheme() ==> connect ==> fontNameChanged Issue: linuxdeepin/dtk#124
deepin-ci-robot
added a commit
to linuxdeepin/qt6integration
that referenced
this pull request
Nov 1, 2023
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#199
zccrs
approved these changes
Nov 6, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kegechen, zccrs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
asterwyx
pushed a commit
to linuxdeepin/qt6integration
that referenced
this pull request
Nov 10, 2023
Synchronize source files from linuxdeepin/qt5integration. Source-pull-request: linuxdeepin/qt5integration#199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onFontChanged will send ApplicationFontChange event to all windows. we stop this opration if qApp set a font
dtk菜单显示了就无效了原因如下：
sub menu ==> draw arrow icon ==> QIcon::fromtheme ==> QIconLoader ==> themeHint(SystemIconThemeName) ==> appTheme() ==> connect ==> fontNameChanged
子菜单需要绘制右箭头图标，用了
QIcon::fromtheme。其实只要那个信号槽连上了就会强制更新。Issue: linuxdeepin/dtk#124