Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V560tu/v540tu/nv4x_adl/ns50 needed staging fixups #1876

Closed
wants to merge 25 commits into from

Conversation

tlaurion
Copy link
Collaborator

@tlaurion tlaurion commented Dec 11, 2024

input for #1846, taking missing commits + adaptations from #1871 so we have builds from CI to test and report on @mkopec

mkopec and others added 24 commits December 4, 2024 12:46
Co-authored-by: Michał Kopeć <[email protected]>
Co-authored-by: Thierry Laurion <[email protected]>
Signed-off-by: Michał Kopeć <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
Signed-off-by: Thierry Laurion <[email protected]>
as a copy of V540TU

Signed-off-by: Michał Kopeć <[email protected]>
Redoing diffs already proposed under linuxboot#1871 but not taken yet....

Signed-off-by: Thierry Laurion <[email protected]>
…linuxboot#1871 but not yet taken under linuxboot#1846

BOOTSPLASH section missing, as well as ME still enabled...

Signed-off-by: Thierry Laurion <[email protected]>
… region, document S3/S01x/Hibernation limitation which is lackking from linuxboot#1846

Signed-off-by: Thierry Laurion <[email protected]>
@tlaurion
Copy link
Collaborator Author

tlaurion commented Dec 11, 2024

Not important, but CircleCI's v540tu/v650tu should depend on x230-hotp-maximized not n4x_adl. Gain in time is minimal reusing nv4x_adl build cache; important here is to reuse crosggc buildstack cached from x230-hotp-maximized, outside of that gains in compilation time is minimal at the cost of passing another unneeded layer of workspace cache for now, since since not reusing the same kernel version anyway? Let's optimize later not now, but note to myself. if we keep different kernel version, this might help otherwise its CI waiting time for nothing?

@mkopec kernel version still needs to be reviewed as needed or not on a v560tu that boots [efifb related, linux version not proven to be necessary as of now for efifb] (waiting for a build that doesn't cause bootloop on my side)

Also name string of v5640 is wrong will post other commit to rebuild when this one is done -> v560tu (board name good, just cosmetic)

@tlaurion tlaurion changed the title V560tu fixups V560tu/v540tu/nv4x_adl/ns50 needed staging fixups Dec 11, 2024
@tlaurion
Copy link
Collaborator Author

tlaurion commented Dec 11, 2024

@mkopec bootloop still with https://output.circle-artifacts.com/output/job/74d3cd5e-9da5-460d-9a29-ea34d475a781/artifacts/0/build/x86/novacustom-v560tu/heads-novacustom-v560tu-v0.2.0-2487-g133d1cd.rom

repro:

  • flashed from stock rom, which I produced screenshot before, with --ifd -i bios -i me -i fd to flash into link provided rom from CI.
  • Let it do its thing. 2 reboots without backlit whitish screen, black screen (Guess is memory training)
  • 3rd reboot: whitish backlit. Each reboot is happening after 90s after power led lights up to reboot. Watchguard of some sort??
  • if I press power button, powers off directly (coreboot behavior prior of linux kicking in)

Nothing I can report more here unfortunately. Can you replicate that this firmware works the same way on your side?
Haven't upgrade EC or anything else here. Whatever you have done to this test laptop that I haven't outside of flashing firmware with built rom would be appreciated to be communicated to me here. OR a test rom built with logs stored into rom to be backup and shared off channel to you or anything you see fit to unblock this. Let me know.

…e to reuse 24.02.01 coreboot buildstack, no point waiting for novacustom_nv4x_adl to be built. Gonna clear cache for next run and build clean

Signed-off-by: Thierry Laurion <[email protected]>
@tlaurion
Copy link
Collaborator Author

@mkopec

python: can't open file '/home/user/heads/build/x86/coreboot-dasharo/3rdparty/fsp/Tools/SplitFspBin.py': [Errno 2] No such file or directory
make[1]: *** [src/drivers/intel/fsp2_0/Makefile.mk:112: novacustom-v560tu/Fsp_M.fd] Error 2

@mkopec
Copy link
Contributor

mkopec commented Dec 18, 2024

Managed to reproduce the freeze, it's freezing while attempting to disable ME:

[DEBUG]  me_state = 2
[DEBUG]  CMOS: me_state = 4294967295
[DEBUG]  ME needs to be disabled.
[ERROR]  HECI: not ready

python: can't open file '/home/user/heads/build/x86/coreboot-dasharo/3rdparty/fsp/Tools/SplitFspBin.py': [Errno 2] No such file or directory
make[1]: *** [src/drivers/intel/fsp2_0/Makefile.mk:112: novacustom-v560tu/Fsp_M.fd] Error 2

Need to run git submodule update in side the coreboot dir

@mkopec
Copy link
Contributor

mkopec commented Dec 18, 2024

@tlaurion I merged your patches into #1846 and added a fix for the ME disable freeze.

@tlaurion
Copy link
Collaborator Author

tlaurion commented Dec 18, 2024

Closing this. Still having this python error, related to something weird in coreboot fork but this is not what this PR was about. Closing

@tlaurion tlaurion closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants