ci: Add conditional reboot for transactional update support #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richm
reviewed
Jan 12, 2024
Co-authored-by: Richard Megginson <[email protected]>
richm
reviewed
Jan 14, 2024
|
one minor nit, otherwise, lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 2 2
Lines 910 910
=======================================
Hits 556 556
Misses 354 354
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Richard Megginson <[email protected]>
richm
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Add Conditional Reboot and README.md Syntax Fix
Reason: To support transactional update systems that require a reboot for changes to take effect and to correct a syntax error in the firewall configuration example in the readme.md.
Result: Ensures that changes on transactional systems are applied correctly if a new package is installed.
Issue Tracker Tickets (Jira or BZ if any):na