Skip to content

Commit

Permalink
Fix spelling
Browse files Browse the repository at this point in the history
  • Loading branch information
spetrosi committed Feb 7, 2025
1 parent 53eeab7 commit 8aa373c
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ Changelog

### Other Changes

- tests: test_ping: fix compatability issues (#171)
- tests: test_ping: fix compatibility issues (#171)

[1.6.0] - 2023-08-08
--------------------
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ permanent change was made to each setting:
### firewall_disable_conflicting_services

By default, the firewall role does not attempt to disable conflicting services due to the
overhead associated with enumerating the services when disabling services is potentially unecessary.
overhead associated with enumerating the services when disabling services is potentially unnecessary.
To enable this feature, set the variable `firewall_disable_conflicting_services` to `true`:

```yaml
Expand Down Expand Up @@ -475,7 +475,7 @@ See `ipset` for more usage information
List of addresses to add or remove from an ipset
Used with `ipset`

Entrys must be compatible with the ipset type of the `ipset`
Entries must be compatible with the ipset type of the `ipset`
being created or modified.

```yaml
Expand Down
2 changes: 1 addition & 1 deletion library/firewall_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@
default: []
interface_pci_id:
description:
List of inteface PCI device ID strings.
List of interface PCI device ID strings.
PCI device ID needs to correspond to a named network interface.
required: false
type: list
Expand Down
6 changes: 3 additions & 3 deletions pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@
# A comma-separated list of package or module names from where C extensions may
# be loaded. Extensions are loading into the active Python interpreter and may
# run arbitrary code
extension-pkg-whitelist=
extension-pkg-whitelist= # codespell:ignore whitelist

# Add files or directories to the blacklist. They should be base names, not
# Add files or directories to the blocklist. They should be base names, not
# paths.
ignore=.git,.tox

# Add files or directories matching the regex patterns to the blacklist. The
# Add files or directories matching the regex patterns to the blocklist. The
# regex matches against base names, not paths.
ignore-patterns=

Expand Down
2 changes: 1 addition & 1 deletion tests/files/test_ping.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ TIMEOUT=2
# The following ping should have 100% packet loss
ping -c "$NUM_PINGS" -W "$TIMEOUT" -i 0.01 "$ip" 1>/tmp/ping0 || :

# Begin downtime comparision #
# Begin downtime comparison #
ping -c "$NUM_PINGS" -W "$TIMEOUT" -i 0.01 "$ip" 1>/tmp/ping1 || : &
pid="$!"
podman exec test-firewalld systemctl reload firewalld.service
Expand Down
4 changes: 2 additions & 2 deletions tests/tests_ansible.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,15 +249,15 @@
register: result
failed_when: result.failed or result.changed

- name: Allow masquerading in permament dmz zone
- name: Allow masquerading in permanent dmz zone
firewall_lib:
masquerade: true
permanent: true
zone: dmz
register: result
failed_when: result.failed or not result.changed

- name: Allow masquerading in permament dmz zone, again
- name: Allow masquerading in permanent dmz zone, again
firewall_lib:
masquerade: true
permanent: true
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_interface_pci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
zone: internal
interface_pci_id: 1af4:0001
state: disabled
permament: true
permanent: true
always:
- name: Cleanup
tags:
Expand Down
4 changes: 2 additions & 2 deletions tests/tests_ipsets.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
- 127.0.0.1
- 8.8.8.8
short: Custom
desciption: Custom IPSet for testing purposes
description: Custom IPSet for testing purposes
state: present
permanent: true

Expand All @@ -63,7 +63,7 @@
firewall:
- ipset: customipset
short: Custom
desciption: Custom IPSet for testing purposes
description: Custom IPSet for testing purposes
state: present
permanent: true
register: result
Expand Down
10 changes: 5 additions & 5 deletions tests/tests_service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@

- name: Fail if systemroletest present prior to test run
fail:
msg: test service present after reseting defaults
msg: test service present after resetting defaults
when: result.stdout.find("systemroletest") != -1

- name: Ensure http has default configuration
Expand Down Expand Up @@ -233,7 +233,7 @@
- 1::1
helper_module: ftp
protocol: icmp
permament: true
permanent: true
state: absent

# Verify nothing is removed in this case
Expand All @@ -256,7 +256,7 @@
- 1::1
helper_module: ftp
protocol: icmp
permament: true
permanent: true
state: absent

- name: Fail if custom service elements changed
Expand Down Expand Up @@ -284,7 +284,7 @@
vars:
firewall:
- service: systemroletest
permament: true
permanent: true
state: absent

- name: Get all services
Expand All @@ -303,7 +303,7 @@
vars:
firewall:
- service: systemroletest
permament: true
permanent: true
state: absent

- name: Fail if second removal changes anything
Expand Down

0 comments on commit 8aa373c

Please sign in to comment.