Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme: add mgmt-addr-list-log command #2659

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

ikegami-t
Copy link
Contributor

Since added the NVMe 2.1 log page.

@ikegami-t
Copy link
Contributor Author

This PR changes depended on the libnvme PR linux-nvme/libnvme#944 changes.

@igaw
Copy link
Collaborator

igaw commented Jan 13, 2025

Looks good. Don't forget to update the tab completion and the documentation. Thanks!

Include libnvme nvme_mi_admin_get_log_mgmt_addr_list().

Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page.

Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page.

Signed-off-by: Tokunori Ikegami <[email protected]>
Since added the NVMe 2.1 log page.

Signed-off-by: Tokunori Ikegami <[email protected]>
@ikegami-t
Copy link
Contributor Author

Yes will do update the tab completion and the documentation later. Just bumped the libnvme revision and added binary output format for now. Thank you.

@igaw igaw merged commit ba27cdb into linux-nvme:master Jan 13, 2025
16 of 17 checks passed
@igaw
Copy link
Collaborator

igaw commented Jan 13, 2025

Thanks!

@ikegami-t ikegami-t mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants