ocp-telemetry-decode: fix ascii string lookup #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igaw
reviewed
Jan 13, 2025
|
Hi @igaw, could you please check? |
|
still not resolved: And I think the second patch should be merged into the first. If not, |
Lookup ascii string in VU Event Identifier String Table for vendor unique event classes. Fix typo. Signed-off-by: Paul Wood <[email protected]>
plmwd
force-pushed
the
fix-string-log-string-lookup
branch
from
3a70a72 to
e76b610
Compare
|
Fixed the issue and squashed. Can you please check @igaw? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lookup ascii string in VU Event Identifier String Table for vendor unique event classes. Fix not looking up spec-defined statistic id name. Fix typo ('static' => 'statistic').