Drug-Drug Interaction #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cked validInteractions
…tions. Still uses DiscreteEvaluator (need to change to AUC metrics)
…teractions splits and folds will have redundant similarity data
…upposed to be unweighted
|
Hello Eriq, I believe the changes are all done. We just need to push the zipped data and maybe consider changing/disabling the weight learning. |
eriq-augustine
requested changes
Sep 27, 2022
There was a problem hiding this comment.
Making some good progress.
There are several repeat comments.
Make sure to double check that you address not just the exact comment, but everything that the comment applies to.
And if you have questions, be sure to ask.
The data archive should extract into a directory named "drug-drug-interaction" (and then the respective sub directories).
This will also need to be reflected in your .data files.
eriq-augustine
requested changes
Sep 28, 2022
eriq-augustine
approved these changes
Sep 28, 2022
eriq-augustine
approved these changes
Sep 28, 2022
eriq-augustine
requested changes
Oct 4, 2022
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue in the main PSL repo. (Make Drug-Drug Prediction into a PSL Example #239 )
The zipped data will need to be uploaded.
EDIT 9/27/22: Data has been reuploaded for proper directory structure.