Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing nativeLB in Traefik #1911

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

GTRekter
Copy link
Contributor

Add missing nativeLB in Traefik

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. To provide additional context, it appears the Traefik example wasn't working without nativeLB: true, which makes sense given what that field is supposed to do (from the IngressRoute CRD):

                       nativeLB:
                       description: |-
                         NativeLB controls, when creating the load-balancer,
                        whether the LB's children are directly the pods IPs or if the only child is the Kubernetes Service clusterIP.
                         The Kubernetes Service itself does load-balance to the pods.
                        By default, NativeLB is false.
                     type: boolean

So basically letting "k8s do the load-balancing", which for us really means letting the proxy do it.
Paging our ingress expert @kflynn for an additional sanity check :-)

Ivan Porta added 2 commits January 18, 2025 00:10
Signed-off-by: Ivan Porta <[email protected]>
Signed-off-by: Ivan Porta <[email protected]>
Ivan Porta added 2 commits January 18, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants