Update retry docs. #1708
Merged
Update retry docs. #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
reviewed
Nov 13, 2023
There was a problem hiding this comment.
overall, this looks good to me; i think that if we're updating the documentation to reflect that requests with bodies are retryable, we should document the length limit for retryable bodies (64KB; see https://github.com/linkerd/linkerd2-proxy/blob/e62cc28ffe59ba9d1906b04a6873bd95ef23a2f7/linkerd/app/outbound/src/http/retry.rs#L41-L42)
Comment on lines
50
to
52
| Retries are supported for _all_ idempotent requests, whatever verb they use | ||
| and whether or not they have bodies. In particular, this means that gRPC | ||
| requests can be retried. |
There was a problem hiding this comment.
we should probably mention the body length limit here, though?
Fixes #1694 Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
kflynn
force-pushed
the
flynn/dev/retry-docs
branch
from
114c769 to
17538b1
Compare
Signed-off-by: Flynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1694
Signed-off-by: Flynn [email protected]