helm: Use k8s EnvVar for proxy.ExperimentalEnv
#11923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siggy
force-pushed
the
siggy/proxy-env-var
branch
from
169df30 to
627bf0d
Compare
adleong
approved these changes
Jan 12, 2024
PR #11874 introduced a `proxy.ExperimentalEnv` setting, allowing arbitrary name+value environment variables on proxies. This name+value pairing was a subset of k8s' environment variables, specifically, it did not allow for `valueFrom.configMapKeyRef` and related fields. PR #11908 introduced this pattern in the ControlPlane containers. Modify `proxy.ExperimentalEnv` to behave identically to k8s' native `EnvVar`, allowing settings such as: ``` --set proxy.experimentalEnv[0].name=LINKERD2_PROXY_DEFROBINATION --set proxy.experimentalEnv[0].valueFrom.configMapKeyRef.key=extreme-key --set proxy.experimentalEnv[0].valueFrom.configMapKeyRef.name=extreme-config ``` Context: #11908 (comment) Signed-off-by: Andrew Seigner <[email protected]>
siggy
force-pushed
the
siggy/proxy-env-var
branch
from
627bf0d to
b6075f0
Compare
mateiidavid
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11874 introduced a
proxy.ExperimentalEnvsetting, allowing arbitrary name+value environment variables on proxies. This name+value pairing was a subset of k8s' environment variables, specifically, it did not allow forvalueFrom.configMapKeyRefand related fields. PR #11908 introduced this pattern in the ControlPlane containers.Modify
proxy.ExperimentalEnvto behave identically to k8s' nativeEnvVar, allowing settings such as:Context:
#11908 (comment)