Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pod Volume Conflict in Linkerd Jaeger Injector #11890

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

moki1202
Copy link
Contributor

@moki1202 moki1202 commented Jan 7, 2024

Fixes #11254

Signed-off-by: Shashank [email protected]

@moki1202 moki1202 requested a review from a team as a code owner January 7, 2024 12:24
@moki1202 moki1202 changed the title Fixes #11524 Fix Pod Volume Conflict in Linkerd Jaeger Injector Jan 7, 2024
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @moki1202

Doesn't the name of the volume need to be updated as well to match the volume mount?

@moki1202 moki1202 force-pushed the fix/duplicate-podinfo-volume branch from b3ad7f5 to 6643006 Compare January 12, 2024 10:51
Signed-off-by: Shashank <[email protected]>
@moki1202 moki1202 force-pushed the fix/duplicate-podinfo-volume branch from 6643006 to ed022e0 Compare January 12, 2024 10:55
@moki1202
Copy link
Contributor Author

My apologies, missed that!

@moki1202
Copy link
Contributor Author

@adleong (not related to this PR) I wanted to ask whether linkerd's taking part in LFX this term(spring). I apologize for asking this here ( I couldn't get a response on slack ;-; )!

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @moki1202 👍

@adleong adleong merged commit 4a77eb6 into linkerd:main Jan 22, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linkerd-jaeger injector fails when pod already has a podinfo volume
3 participants