helm: Add experimentalArgs to destination and policy controllers #11862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging controller behavior, it may desirable to run a controller with additional command-line flags that aren't explicitly referenced in our values.yaml. This change adds support for undocumented experimentalArgs values that can be set on the policyController and destinationController parent scopes.
alpeb
approved these changes
Jan 2, 2024
|
Tested manually with |
mateiidavid
approved these changes
Jan 4, 2024
siggy
added a commit
that referenced
this pull request
Jan 10, 2024
Enable setting arbitrary environment variables on all Go-based Control
Plane containers
For example, via CLI:
```
--set destinationController.experimentalEnv[0].name=ENV_VAR,destinationController.experimentalEnv[0].value=ENV_VAL
```
Via values file:
```
destinationController:
experimentalEnv:
- name: DEST_ENV_VAR
value: DEST_ENV_VAL
- name: DEST_CONFIG_MAP_VAR
valueFrom:
configMapKeyRef:
key: dest_config_map_key
name: dest-config-map-name
heartbeat:
experimentalEnv:
identity:
experimentalEnv:
proxyInjector:
experimentalEnv:
serviceMirror:
experimentalEnv:
spValidator:
experimentalEnv:
```
Relates to #11862 and #11874
Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this pull request
Jan 10, 2024
Enable setting arbitrary environment variables on all Go-based Control
Plane containers
For example, via CLI:
```
--set destinationController.experimentalEnv[0].name=ENV_VAR,destinationController.experimentalEnv[0].value=ENV_VAL
```
Via values file:
```
destinationController:
experimentalEnv:
- name: DEST_ENV_VAR
value: DEST_ENV_VAL
- name: DEST_CONFIG_MAP_VAR
valueFrom:
configMapKeyRef:
key: dest_config_map_key
name: dest-config-map-name
heartbeat:
experimentalEnv:
identity:
experimentalEnv:
proxyInjector:
experimentalEnv:
spValidator:
experimentalEnv:
serviceMirrorExperimentalEnv:
```
Relates to #11862 and #11874
Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this pull request
Jan 10, 2024
Enable setting arbitrary environment variables on all Go-based Control
Plane containers
For example, via CLI:
```
--set destinationController.experimentalEnv[0].name=ENV_VAR,destinationController.experimentalEnv[0].value=ENV_VAL
```
Via values file:
```
destinationController:
experimentalEnv:
- name: DEST_ENV_VAR
value: DEST_ENV_VAL
- name: DEST_CONFIG_MAP_VAR
valueFrom:
configMapKeyRef:
key: dest_config_map_key
name: dest-config-map-name
heartbeat:
experimentalEnv:
identity:
experimentalEnv:
proxyInjector:
experimentalEnv:
spValidator:
experimentalEnv:
serviceMirrorExperimentalEnv:
```
Relates to #11862 and #11874
Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this pull request
Jan 10, 2024
Enable setting arbitrary environment variables on all Go-based Control
Plane containers
For example, via CLI:
```
--set destinationController.experimentalEnv[0].name=ENV_VAR,destinationController.experimentalEnv[0].value=ENV_VAL
```
Via values file:
```
destinationController:
experimentalEnv:
- name: DEST_ENV_VAR
value: DEST_ENV_VAL
- name: DEST_CONFIG_MAP_VAR
valueFrom:
configMapKeyRef:
key: dest_config_map_key
name: dest-config-map-name
heartbeat:
experimentalEnv:
identity:
experimentalEnv:
proxyInjector:
experimentalEnv:
spValidator:
experimentalEnv:
serviceMirrorExperimentalEnv:
```
Relates to #11862 and #11874
Signed-off-by: Andrew Seigner <[email protected]>
siggy
added a commit
that referenced
this pull request
Jan 10, 2024
Enable setting arbitrary environment variables on all Go-based Control
Plane containers
For example, via CLI:
```
--set destinationController.experimentalEnv[0].name=ENV_VAR,destinationController.experimentalEnv[0].value=ENV_VAL
```
Via values file:
```
destinationController:
experimentalEnv:
- name: DEST_ENV_VAR
value: DEST_ENV_VAL
- name: DEST_CONFIG_MAP_VAR
valueFrom:
configMapKeyRef:
key: dest_config_map_key
name: dest-config-map-name
heartbeat:
experimentalEnv:
identity:
experimentalEnv:
proxyInjector:
experimentalEnv:
spValidator:
experimentalEnv:
serviceMirrorExperimentalEnv:
```
Relates to #11862 and #11874
Signed-off-by: Andrew Seigner <[email protected]>
mateiidavid
pushed a commit
that referenced
this pull request
Jan 12, 2024
Enable setting arbitrary environment variables on all Go-based Control
Plane containers
For example, via CLI:
```
--set destinationController.experimentalEnv[0].name=ENV_VAR,destinationController.experimentalEnv[0].value=ENV_VAL
```
Via values file:
```
destinationController:
experimentalEnv:
- name: DEST_ENV_VAR
value: DEST_ENV_VAL
- name: DEST_CONFIG_MAP_VAR
valueFrom:
configMapKeyRef:
key: dest_config_map_key
name: dest-config-map-name
heartbeat:
experimentalEnv:
identity:
experimentalEnv:
proxyInjector:
experimentalEnv:
spValidator:
experimentalEnv:
serviceMirrorExperimentalEnv:
```
Relates to #11862 and #11874
Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging controller behavior, it may desirable to run a controller with additional command-line flags that aren't explicitly referenced in our values.yaml.
This change adds support for undocumented experimentalArgs values that can be set on the policyController and destinationController parent scopes.