Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min Kubernetes API to v1.22 #11737

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Bump min Kubernetes API to v1.22 #11737

merged 4 commits into from
Dec 11, 2023

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Dec 11, 2023

New versions of the k8s-openapi crate drop support for Kubernetes 1.21. Kubernetes v1.22 has been considered EOL by the upstream project since 2022-07-08. Major cloud providers have EOL'd it as well (GKE's current MSKV is 1.24).

This change updates the MSKV to v1.22. It also updates the max version in _test-helpers.sh to v1.28.

@olix0r olix0r requested a review from a team as a code owner December 11, 2023 14:59
@olix0r olix0r marked this pull request as draft December 11, 2023 15:24
New versions of the k8s-openapi crate drop support for Kubernetes 1.22.
Kubernetes v1.22 has been considered EOL by the upstream project since
2022-07-08. Major cloud providers have EOL'd it as well (GKE's current
MSKV is 1.24).

This change updates the MSKV to v1.22. It also updates the max version
in _test-helpers.sh to v1.28.
@olix0r olix0r marked this pull request as ready for review December 11, 2023 15:26
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the README.md.gotmpl files have a hard-coded mention to 1.21. Not sure if that can be templated though.

It's included in the version info section.
@olix0r
Copy link
Member Author

olix0r commented Dec 11, 2023

@alpeb I removed the version reference in the README blurb, since it's included in the version info section read from the chart.yaml

Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@olix0r olix0r merged commit 5f100b3 into main Dec 11, 2023
47 checks passed
@olix0r olix0r deleted the ver/bump-mskv branch December 11, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants