Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions (gha) cache for Docker builds #11605

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Use GitHub Actions (gha) cache for Docker builds #11605

merged 2 commits into from
Nov 14, 2023

Conversation

siggy
Copy link
Member

@siggy siggy commented Nov 12, 2023

Docker introduced a gha cache type, removing the need to manage our
own Docker cache in CI.

Modify the docker-build action to set required ACTIONS_CACHE_URL and
ACTIONS_RUNTIME_TOKEN environment variables, consumed by
docker buildx commands.

Cached Docker build times reduced to 15s ~ 1m45s.

Screenshot 2023-11-11 at 11 26 23 PM

@siggy siggy requested a review from a team as a code owner November 12, 2023 05:47
@siggy siggy marked this pull request as draft November 12, 2023 05:49
@siggy siggy changed the title wip: gha cache testing Use GitHub Actions gha cache for Docker builds Nov 12, 2023
@siggy siggy changed the title Use GitHub Actions gha cache for Docker builds Use GitHub Actions (gha) cache for Docker builds Nov 12, 2023
Docker introduced a `gha` cache type, removing the need to manage our
own Docker cache in CI.

Modify the `docker-build` action to set required `ACTIONS_CACHE_URL` and
`ACTIONS_RUNTIME_TOKEN` environment variables, consumed by
`docker buildx` commands.

Cached Docker build times reduced to 15s ~ 1m45s.

Signed-off-by: Andrew Seigner <[email protected]>
@siggy siggy marked this pull request as ready for review November 12, 2023 09:40
Copy link
Member

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool! Thanks a lot! 🚢

bin/_docker.sh Outdated Show resolved Hide resolved
.github/actions/docker-build/action.yml Show resolved Hide resolved
@siggy siggy self-assigned this Nov 13, 2023
@mateiidavid mateiidavid merged commit 80ce4e6 into linkerd:main Nov 14, 2023
33 checks passed
@siggy siggy deleted the siggy/gha branch November 14, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants