Fix annotation names and partials field #11560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to setting an enormous value to disable protocol detection, the field was meant to be configurable. In the refactor, the annotation name stayed the same instead of reflecting the change in the contract (i.e. not configurable but toggled). Additionally, there were two types in the proxy partials. Signed-off-by: Matei David <[email protected]>
Testing:With install time value for outbound detect timeout and an annotation for inbound: |
olix0r
approved these changes
Nov 2, 2023
adleong
approved these changes
Nov 2, 2023
adleong
pushed a commit
that referenced
this pull request
Nov 16, 2023
Prior to setting an enormous value to disable protocol detection, the field was meant to be configurable. In the refactor, the annotation name stayed the same instead of reflecting the change in the contract (i.e. not configurable but toggled). Additionally, there were two types in the proxy partials. Signed-off-by: Matei David <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to setting an enormous value to disable protocol detection, the field was meant to be configurable. In the refactor, the annotation name stayed the same instead of reflecting the change in the contract (i.e. not configurable but toggled). Additionally, there were two types in the proxy partials.