Skip to content

Commit

Permalink
Set minimum TLS version to 1.3 (#13500)
Browse files Browse the repository at this point in the history
This helps ensure a minimum level of security. The two places this affects is our controller webhook and linkerd-viz tap API.

The controller requires that kube-api supports TLSv1.3, which it does as of 1.19 (our minimum is currently 1.22). The linkerd-viz tap API is mostly used internally, and is deprecated. It may be worth revisiting if we want to keep it around at all.

Signed-off-by: Scott Fleener <[email protected]>
  • Loading branch information
sfleen authored Dec 19, 2024
1 parent c77075c commit 3847f9c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion controller/webhook/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func NewServer(
Addr: addr,
ReadHeaderTimeout: 15 * time.Second,
TLSConfig: &tls.Config{
MinVersion: tls.VersionTLS12,
MinVersion: tls.VersionTLS13,
},
}

Expand Down
2 changes: 1 addition & 1 deletion controller/webhook/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ var mockHTTPServer = &http.Server{
Addr: ":0",
ReadHeaderTimeout: 15 * time.Second,
TLSConfig: &tls.Config{
MinVersion: tls.VersionTLS12,
MinVersion: tls.VersionTLS13,
},
}

Expand Down
2 changes: 1 addition & 1 deletion viz/tap/api/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func NewServer(
TLSConfig: &tls.Config{
ClientAuth: tls.VerifyClientCertIfGiven,
ClientCAs: clientCertPool,
MinVersion: tls.VersionTLS12,
MinVersion: tls.VersionTLS13,
},
}

Expand Down

0 comments on commit 3847f9c

Please sign in to comment.