New option to reuse buffers when appending records #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuzic
reviewed
Apr 2, 2021
| deflateBlock = make([]byte, 0, len(block)) | ||
| } | ||
|
|
||
| bb := bytes.NewBuffer(deflateBlock) |
There was a problem hiding this comment.
may be in one style ?
var bb = bytes.NewBuffer(deflateBlock)
|
Hi are you still there? Are you still interested in discussing this PR? |
|
@xmcqueen Yes I'm still there. Do you have any remark/question? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have similar record lists to append to a file, reusing some internal slices saves memory and seems to significantly improve the performances.
On my computer:
The only strange thing is that reusing buffers takes less memory with deflate than without compression (but it is slower, which is consistent).
Do you think that it would interesting to add a such option?