Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINBEE-9077 - add the ability to skip clone + download artifact #101

Closed
wants to merge 13 commits into from

Conversation

yeelali14
Copy link
Collaborator

workerB

  • Implement the option to bypass cloning based on the shouldUseCache and isCacheEnable boolean flags
  • Inject 3 env variables into gitstream-core: SHOULD_USE_CACHE, IS_CACHE_ENABLE, and RUN_DATA_CACHE
  • This code won't activate the cache unless we add logic in gitstream-sls-pipeline to calculate shouldUseCache, isCacheEnable, and artifactRunId

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link

@jit-ci jit-ci bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Jit has detected 1 important finding in this PR that you should review.
The finding is detailed below as a comment.
It’s highly recommended that you fix this security issue before merge.

@@ -36,7 +36,7 @@
"license": "Apache-2.0",
"dependencies": {
"@actions/core": "^1.10.1",
"@linearb/gitstream-core": "2.1.33"
"@linearb/gitstream-core": "2.1.33-13"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security control: Software Component Analysis Js

Type: Server-Side Request Forgery In Axios

Description: @linearb/gitstream-core>axios

Severity: HIGH

Learn more about this issue



Jit Bot commands and options (e.g., ignore issue)

You can trigger Jit actions by commenting on this PR review:

  • #jit_ignore_fp Ignore and mark this specific single instance of finding as “False Positive”
  • #jit_ignore_accept Ignore and mark this specific single instance of finding as “Accept Risk”
  • #jit_ignore_type_in_file Ignore any finding of type "Server-Side Request Forgery in axios" in package.json
  • #jit_undo_ignore Undo ignore command

@yeelali14 yeelali14 closed this Aug 13, 2024
@MishaKav MishaKav deleted the LINBEE-9077-1 branch November 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant