Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChannelAPIClient shouldn't require channelToken #392

Merged
merged 1 commit into from
Nov 17, 2023
Merged

ChannelAPIClient shouldn't require channelToken #392

merged 1 commit into from
Nov 17, 2023

Conversation

tokuhirom
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d920a8d) 55.68% compared to head (adf5212) 55.68%.

❗ Current head adf5212 differs from pull request most recent head cdff9ce. Consider uploading reports for the commit cdff9ce to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   55.68%   55.68%           
=======================================
  Files          86       86           
  Lines        5414     5414           
=======================================
  Hits         3015     3015           
  Misses       2179     2179           
  Partials      220      220

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Yang-33
Yang-33 approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@Yang-33 Yang-33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@Yang-33 Yang-33 merged commit 0f8cb3f into line:master Nov 17, 2023
4 checks passed
@Yang-33 Yang-33 mentioned this pull request Nov 17, 2023
Closed
@tokuhirom tokuhirom deleted the channel-access-token-doesnt-require-auth-token branch November 17, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yang-33 Yang-33 Yang-33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tokuhirom @codecov-commenter @Yang-33