Add WithResult methods to take HTTP headers, if needed. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #387 +/- ##
=======================================
Coverage 55.68% 55.68%
=======================================
Files 86 86
Lines 5414 5414
=======================================
Hits 3015 3015
Misses 2179 2179
Partials 220 220 ☔ View full report in Codecov by Sentry. |
Yang-33
approved these changes
Nov 7, 2023
linebot/insight/api_insight.go
Outdated
| date, | ||
| ) | ||
|
|
||
| defer response.Body.Close() |
There was a problem hiding this comment.
is there any problem calling defer response.Body.Close() twice ...? ~WithHttpInfo calls defer res.Body.Close() and original methods call defer response.Body.Close() again.
Yang-33
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.