Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify entity, join serializers to allow specify entity() as the on clause predicate #730

Closed
wants to merge 5 commits into from

Conversation

sjnqkqh
Copy link
Contributor

@sjnqkqh sjnqkqh commented Jun 25, 2024

Motivation

Modifications

  • Add Join, On clause to JpqlRenderClause
  • Modified conditional statements to include Join, On clause in EntitySerialiser (so that 'AS alias' is not added when serialising entities in On clause)
  • Add code to update JpqlRenderClause to Join, On in FetchJoin, Join, Association join serialisers
  • Modify test code according to serialiser modification

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • 'AS [alias]' is not added when writing predicates for entity() in On clauses

Closes

  • #{issue number} (If this PR resolves an issue.)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.96%. Comparing base (9a6be26) to head (8757fae).

Files Patch % Lines
...linjdsl/render/jpql/serializer/JpqlRenderClause.kt 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   91.96%   91.96%           
=======================================
  Files         335      335           
  Lines        3423     3449   +26     
  Branches      203      205    +2     
=======================================
+ Hits         3148     3172   +24     
- Misses        213      215    +2     
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants