Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the missing single quotation surrounding the function name of JpqlFunctionSerializer. #534

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

cj848
Copy link
Collaborator

@cj848 cj848 commented Nov 22, 2023

Motivation

  • The JPQL Function function is not operating properly. It should be created as function('function_name', ...), but it is created as function(function_name), making normal query execution impossible.

-- korean

  • JPQL Function 기능이 정상적으로 동작하고 있지 않습니다. function('function_name', ...) 으로 생성 되어야 하지만 function(function_name) 으로 생성되고 있어 정상적인 쿼리 수행이 불가능합니다.

Modifications

  • Added a modification to wrap a single quotation in front of part.name of JpqlFunctionSerializer.

-- korean

  • JpqlFunctionSerializer 의 part.name 앞에 single quotation 을 감싸는 수정을 추가하였습니다.

Result

  • You can now use JPQL functions normally.

-- korean

  • JPQL의 function 을 정상적으로 사용할 수 있게 됩니다.

Closes

@cj848 cj848 force-pushed the fix/bugfix-function-serializer branch from 1a6d855 to 8233f0c Compare November 22, 2023 06:09
@shouwn shouwn merged commit 0919332 into line:develop Nov 22, 2023
3 checks passed
@cj848 cj848 deleted the fix/bugfix-function-serializer branch November 22, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants