Skip to content

Commit

Permalink
Merge branch 'develop' into feat/ln
Browse files Browse the repository at this point in the history
  • Loading branch information
shouwn authored Feb 5, 2024
2 parents 3f049da + b480368 commit a6767b1
Show file tree
Hide file tree
Showing 12 changed files with 189 additions and 4 deletions.
4 changes: 3 additions & 1 deletion docs/en/jpql-with-kotlin-jdsl/expressions.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,7 @@ Use the following functions to build arithmetic functions:

* ABS (abs)
* CEILING (ceiling)
* EXP (exp)
* FLOOR (floor)
* LN (ln)
* ROUND (round)
Expand All @@ -235,6 +236,8 @@ abs(path(Book::price))

ceiling(path(Book::price))

exp(path(Book::price))

floor(path(Book::price))

ln(path(Book::price))
Expand All @@ -246,7 +249,6 @@ sqrt(path(Book::price))

| Function | DSL function |
|----------|--------------|
| EXP | not yet |
| MOD | not yet |
| POWER | not yet |
| SIGN | not yet |
Expand Down
4 changes: 3 additions & 1 deletion docs/ko/jpql-with-kotlin-jdsl/expressions.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ locate("Book", path(Book::title))

* ABS (abs)
* CEILING (ceiling)
* EXP (exp)
* FLOOR (floor)
* LN (ln)
* ROUND (round)
Expand All @@ -231,6 +232,8 @@ abs(path(Book::price))

ceiling(path(Book::price))

exp(path(Book::price))

floor(path(Book::price))

ln(path(Book::price))
Expand All @@ -242,7 +245,6 @@ sqrt(path(Book::price))

| Function | DSL function |
|----------|--------------|
| EXP | not yet |
| MOD | not yet |
| POWER | not yet |
| SIGN | not yet |
Expand Down
16 changes: 16 additions & 0 deletions dsl/jpql/src/main/kotlin/com/linecorp/kotlinjdsl/dsl/jpql/Jpql.kt
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,22 @@ open class Jpql : JpqlDsl {
return Expressions.ceiling(value.toExpression())
}

/**
* Creates an expression that represents the exponential value.
*/
@SinceJdsl("3.4.0")
fun <T : Any, V : Number> exp(expr: KProperty1<T, @Exact V>): Expression<Double> {
return Expressions.exp(Paths.path(expr))
}

/**
* Creates an expression that represents the exponential value.
*/
@SinceJdsl("3.4.0")
fun <T : Number> exp(value: Expressionable<T>): Expression<Double> {
return Expressions.exp(value.toExpression())
}

/**
* Creates an expression that is enclosed in floor.
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package com.linecorp.kotlinjdsl.dsl.jpql.expression

import com.linecorp.kotlinjdsl.dsl.jpql.entity.book.Book
import com.linecorp.kotlinjdsl.dsl.jpql.queryPart
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.Expression
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.Expressions
import com.linecorp.kotlinjdsl.querymodel.jpql.path.Paths
import org.assertj.core.api.WithAssertions
import org.junit.jupiter.api.Test

class ExpDslTest : WithAssertions {
private val expression1 = Paths.path(Book::salePrice)

@Test
fun `exp() with a property`() {
// when
val expression = queryPart {
exp(Book::price)
}.toExpression()

val actual: Expression<Double> = expression // for type check

// then
val expected = Expressions.exp(
value = Paths.path(Book::price),
)

assertThat(actual).isEqualTo(expected)
}

@Test
fun `exp() with a expression`() {
// when
val expression = queryPart {
exp(expression1)
}.toExpression()

val actual: Expression<Double> = expression // for type check

// then
val expected = Expressions.exp(
value = expression1,
)

assertThat(actual).isEqualTo(expected)
}
}
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.6-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
2 changes: 1 addition & 1 deletion libs.example.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spring-batch4-test = { module = "org.springframework.batch:spring-batch-test", v

# hibernate
hibernate5-core = { module = "org.hibernate:hibernate-core", version = "5.6.15.Final" }
hibernate6-core = { module = "org.hibernate:hibernate-core", version = "6.4.2.Final" }
hibernate6-core = { module = "org.hibernate:hibernate-core", version = "6.4.3.Final" }

# hibernate-reactive
hibernate-reactive1-core = { module = "org.hibernate.reactive:hibernate-reactive-core", version = "1.1.9.Final" }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlCount
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlCustomExpression
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlDivide
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlEntityType
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExp
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExpression
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExpressionParentheses
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlFloor
Expand Down Expand Up @@ -228,6 +229,14 @@ object Expressions {
return JpqlCeiling(value)
}

/**
* Creates an expression that represents the exponential value.
*/
@SinceJdsl("3.4.0")
fun <T : Number> exp(value: Expression<T>): Expression<Double> {
return JpqlExp(value)
}

/**
* Creates an expression that is enclosed in floor.
*/
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl

import com.linecorp.kotlinjdsl.Internal
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.Expression

/**
* Expression that applies exponential function to [value].
*/
@Internal
data class JpqlExp<T : Number> internal constructor(
val value: Expression<T>,
) : Expression<Double>
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlCount
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlCustomExpression
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlDivide
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlEntityType
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExp
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExpression
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExpressionParentheses
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlFloor
Expand Down Expand Up @@ -364,6 +365,19 @@ class ExpressionsTest : WithAssertions {
assertThat(actual).isEqualTo(expected)
}

@Test
fun exp() {
// when
val actual = Expressions.exp(doubleExpression1)

// then
val expected = JpqlExp(
doubleExpression1,
)

assertThat(actual).isEqualTo(expected)
}

@Test
fun floor() {
// when
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlEqualAllSerialize
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlEqualAnySerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlEqualSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlExistsSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlExpSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlExpressionParenthesesSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlExpressionSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.impl.JpqlFloorSerializer
Expand Down Expand Up @@ -290,6 +291,7 @@ private class DefaultModule : JpqlRenderModule {
JpqlExistsSerializer(),
JpqlExpressionParenthesesSerializer(),
JpqlExpressionSerializer(),
JpqlExpSerializer(),
JpqlFloorSerializer(),
JpqlFunctionExpressionSerializer(),
JpqlFunctionPredicateSerializer(),
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.linecorp.kotlinjdsl.render.jpql.serializer.impl

import com.linecorp.kotlinjdsl.Internal
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExp
import com.linecorp.kotlinjdsl.render.RenderContext
import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlRenderSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlSerializer
import com.linecorp.kotlinjdsl.render.jpql.writer.JpqlWriter
import kotlin.reflect.KClass

@Internal
class JpqlExpSerializer : JpqlSerializer<JpqlExp<*>> {
override fun handledType(): KClass<JpqlExp<*>> {
return JpqlExp::class
}

override fun serialize(part: JpqlExp<*>, writer: JpqlWriter, context: RenderContext) {
val delegate = context.getValue(JpqlRenderSerializer)

writer.write("EXP")

writer.writeParentheses {
delegate.serialize(part.value, writer, context)
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
package com.linecorp.kotlinjdsl.render.jpql.serializer.impl

import com.linecorp.kotlinjdsl.querymodel.jpql.expression.Expressions
import com.linecorp.kotlinjdsl.querymodel.jpql.expression.impl.JpqlExp
import com.linecorp.kotlinjdsl.querymodel.jpql.path.Paths
import com.linecorp.kotlinjdsl.render.TestRenderContext
import com.linecorp.kotlinjdsl.render.jpql.entity.book.Book
import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlRenderSerializer
import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlSerializerTest
import com.linecorp.kotlinjdsl.render.jpql.writer.JpqlWriter
import io.mockk.impl.annotations.MockK
import io.mockk.verifySequence
import org.assertj.core.api.WithAssertions
import org.junit.jupiter.api.Test

@JpqlSerializerTest
class JpqlExpSerializerTest : WithAssertions {
private val sut = JpqlExpSerializer()

@MockK
private lateinit var writer: JpqlWriter

@MockK
private lateinit var serializer: JpqlRenderSerializer

private val expression1 = Paths.path(Book::price)

@Test
fun handledType() {
// when
val actual = sut.handledType()

// then
assertThat(actual).isEqualTo(JpqlExp::class)
}

@Test
fun serialize() {
// given
val part = Expressions.exp(
value = expression1,
)
val context = TestRenderContext(serializer)

// when
sut.serialize(part as JpqlExp<*>, writer, context)

// then
verifySequence {
writer.write("EXP")
writer.writeParentheses(any())
serializer.serialize(expression1, writer, context)
}
}
}

0 comments on commit a6767b1

Please sign in to comment.