fix: render false condition for in condition if the compare values is…

… empty
line · May 4, 2024 · 25ce71b · 25ce71b
1 parent a33bf96
commit 25ce71b
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 26 deletions.
diff --git a/...l/src/main/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlInSerializer.kt b/...l/src/main/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlInSerializer.kt
@@ -19,18 +19,18 @@ class JpqlInSerializer : JpqlSerializer<JpqlIn<*>> {
         val delegate = context.getValue(JpqlRenderSerializer)
 
         if (IterableUtils.isEmpty(part.compareValues)) {
-            return
-        }
-
-        delegate.serialize(part.value, writer, context)
+            writer.write("0 = 1")
+        } else {
+            delegate.serialize(part.value, writer, context)
 
-        writer.write(" ")
-        writer.write("IN")
-        writer.write(" ")
+            writer.write(" ")
+            writer.write("IN")
+            writer.write(" ")
 
-        writer.writeParentheses {
-            writer.writeEach(part.compareValues, separator = ", ") {
-                delegate.serialize(it, writer, context)
+            writer.writeParentheses {
+                writer.writeEach(part.compareValues, separator = ", ") {
+                    delegate.serialize(it, writer, context)
+                }
             }
         }
     }

diff --git a/...rc/main/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlNotInSerializer.kt b/...rc/main/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlNotInSerializer.kt
@@ -19,18 +19,18 @@ class JpqlNotInSerializer : JpqlSerializer<JpqlNotIn<*>> {
         val delegate = context.getValue(JpqlRenderSerializer)
 
         if (IterableUtils.isEmpty(part.compareValues)) {
-            return
-        }
-
-        delegate.serialize(part.value, writer, context)
+            writer.write("0 = 1")
+        } else {
+            delegate.serialize(part.value, writer, context)
 
-        writer.write(" ")
-        writer.write("NOT IN")
-        writer.write(" ")
+            writer.write(" ")
+            writer.write("NOT IN")
+            writer.write(" ")
 
-        writer.writeParentheses {
-            writer.writeEach(part.compareValues, separator = ", ") {
-                delegate.serialize(it, writer, context)
+            writer.writeParentheses {
+                writer.writeEach(part.compareValues, separator = ", ") {
+                    delegate.serialize(it, writer, context)
+                }
             }
         }
     }

diff --git a/...c/test/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlInSerializerTest.kt b/...c/test/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlInSerializerTest.kt
@@ -9,7 +9,6 @@ import com.linecorp.kotlinjdsl.render.jpql.entity.book.Book
 import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlRenderSerializer
 import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlSerializerTest
 import com.linecorp.kotlinjdsl.render.jpql.writer.JpqlWriter
-import io.mockk.called
 import io.mockk.impl.annotations.MockK
 import io.mockk.verifySequence
 import org.assertj.core.api.WithAssertions
@@ -73,7 +72,7 @@ class JpqlInSerializerTest : WithAssertions {
     }
 
     @Test
-    fun `serialize() draws nothing, when the compareValues is empty`() {
+    fun `serialize() draws 0 = 1, when the compareValues is empty`() {
         // Given
         val part = Predicates.`in`(
             expression1,
@@ -86,7 +85,7 @@ class JpqlInSerializerTest : WithAssertions {
 
         // Then
         verifySequence {
-            writer wasNot called
+            writer.write("0 = 1")
         }
     }
 }
diff --git a/...est/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlNotInSerializerTest.kt b/...est/kotlin/com/linecorp/kotlinjdsl/render/jpql/serializer/impl/JpqlNotInSerializerTest.kt
@@ -9,7 +9,6 @@ import com.linecorp.kotlinjdsl.render.jpql.entity.book.Book
 import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlRenderSerializer
 import com.linecorp.kotlinjdsl.render.jpql.serializer.JpqlSerializerTest
 import com.linecorp.kotlinjdsl.render.jpql.writer.JpqlWriter
-import io.mockk.called
 import io.mockk.impl.annotations.MockK
 import io.mockk.verifySequence
 import org.assertj.core.api.WithAssertions
@@ -73,7 +72,7 @@ class JpqlNotInSerializerTest : WithAssertions {
     }
 
     @Test
-    fun `serialize() draws nothing, when the compareValues is empty`() {
+    fun `serialize() draws 0 = 1, when the compareValues is empty`() {
         // Given
         val part = Predicates.notIn(
             expression1,
@@ -86,7 +85,7 @@ class JpqlNotInSerializerTest : WithAssertions {
 
         // Then
         verifySequence {
-            writer wasNot called
+            writer.write("0 = 1")
         }
     }
 }