Skip to content

Commit

Permalink
Merge pull request #87 from YkSix/increase_minSdk_to_align_AosLineSdk
Browse files Browse the repository at this point in the history
Bump Android LINE SDK version to 5.9.1 and minSdk to 24
  • Loading branch information
onevcat authored Nov 16, 2023
2 parents 736eacd + 63fa14a commit 5f98af6
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 12 deletions.
19 changes: 18 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,24 @@ target 'Runner' do

#### Android

No specific settings are required.
To ensure compatibility with the latest features, you need to update the `minSdk` version in your app's `build.gradle` file to `24` or higher.

Here's how you can do it:

1. Open your app's `build.gradle` file.
2. Locate the `android` block, and within it, find the `defaultConfig` block.
3. In the `defaultConfig` block, replace the current `minSdk` value with `24`.

Here's a diff to show what your changes might look like:

```diff
android {
defaultConfig {
- minSdk flutter.minSdkVersion
+ minSdk 24
}
}
```

### Importing and using

Expand Down
9 changes: 4 additions & 5 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:7.0.1'
classpath 'com.android.tools.build:gradle:7.3.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}


}

rootProject.allprojects {
Expand All @@ -27,13 +26,13 @@ apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 31
compileSdk 33

sourceSets {
main.java.srcDirs += 'src/main/kotlin'
}
defaultConfig {
minSdkVersion 21
minSdk 24
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles 'consumer-proguard-rules.pro'
}
Expand All @@ -43,7 +42,7 @@ android {
}

dependencies {
implementation('com.linecorp.linesdk:linesdk:5.8.1') {
implementation('com.linecorp.linesdk:linesdk:5.9.1') {
exclude group: 'androidx.lifecycle', module: 'lifecycle-viewmodel-ktx'
}
implementation 'com.google.code.gson:gson:2.8.5'
Expand Down
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip
6 changes: 3 additions & 3 deletions example/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ apply plugin: 'kotlin-android'
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"

android {
compileSdkVersion 31
compileSdk 33

sourceSets {
main.java.srcDirs += 'src/main/kotlin'
Expand All @@ -38,8 +38,8 @@ android {

defaultConfig {
applicationId "com.linecorp.linesdk.sample"
minSdkVersion 24
targetSdkVersion 31
minSdk 24
targetSdk 31
versionCode flutterVersionCode.toInteger()
versionName flutterVersionName
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
Expand Down
2 changes: 1 addition & 1 deletion example/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:7.0.1'
classpath 'com.android.tools.build:gradle:7.3.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
Expand Down
2 changes: 1 addition & 1 deletion example/android/gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.6-bin.zip

0 comments on commit 5f98af6

Please sign in to comment.