Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GrpcHealthCheckedEndpointGroupBuilder #6078

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wvuong
Copy link

@wvuong wvuong commented Jan 22, 2025

Motivation:

Add GrpcHealthCheckedEndpointGroupBuilder which builds a health checked endpoint group whose health comes from a standard gRPC health check service result.

Modifications:

  • Adds GrpcHealthCheckedEndpointGroupBuilder which extends AbstractHealthCheckedEndpointGroupBuilder and creates a new health check function
  • Adds GrpcHealthChecker which is the health check function that creates and uses a gRPC HealthGrpc stub to check the gRPC health service on the endpoint. If the health check response is SERVING, it is healthy. It is unhealthy if the response is not SERVING or if there was a request failure.
  • Adds tests.

Result:

Motivation:

Add `GrpcHealthCheckedEndpointGroupBuilder` which builds a health checked endpoint group whose health comes from a [standard gRPC health check service result](https://grpc.io/docs/guides/health-checking/).

Modifications:

* Adds `GrpcHealthCheckedEndpointGroupBuilder` which extends `AbstractHealthCheckedEndpointGroupBuilder` and creates a new health check function
* Adds `GrpcHealthChecker` which is the health check function that creates and uses a gRPC `HealthGrpc` stub to check the gRPC health service on the endpoint. If the health check response is `SERVING`, it is healthy. It is unhealthy if the response is not `SERVING` or if there was a request failure.
* Adds tests.

Result:

* A user can create a health checked endpoint group that is backed by a gRPC health check service.
* Closes line#5930
@CLAassistant
Copy link

CLAassistant commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for gRPC health check endpoint
2 participants