Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ubicloud-standard-16 to run CI builds #6065

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use ubicloud-standard-16 to run CI builds #6065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions .github/workflows/actions_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,25 +32,25 @@ jobs:
strategy:
fail-fast: false
matrix:
on: [ ubicloud-standard-8, macos-latest, windows-latest ]
on: [ ubicloud-standard-16, macos-latest, windows-latest ]
java: [ 21 ]
include:
- java: 8
on: ubicloud-standard-8
on: ubicloud-standard-16
- java: 11
on: ubicloud-standard-8
on: ubicloud-standard-16
- java: 17
on: ubicloud-standard-8
on: ubicloud-standard-16
leak: true
- java: 17
on: ubicloud-standard-8
on: ubicloud-standard-16
min-java: 11
- java: 17
on: ubicloud-standard-8
on: ubicloud-standard-16
min-java: 17
coverage: true
- java: 21
on: ubicloud-standard-8
on: ubicloud-standard-16
snapshot: true
# blockhound makes the build run about 10 minutes slower
blockhound: true
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
- name: Build with Gradle (Shading only)
run: |
./gradlew --no-daemon --stacktrace shadedJar shadedTestJar trimShadedJar \
${{ startsWith(matrix.on, 'ubicloud') && '--max-workers=8' || '--max-workers=2' }} --parallel \
${{ startsWith(matrix.on, 'ubicloud') && '--max-workers=12' || '--max-workers=2' }} --parallel \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just keeping it as 8 even though there are 16 vCPU?
I think 8 workers are enough and we changed this machine due to the memory issue. 😉

${{ matrix.coverage && '-Pcoverage' || '' }} \
-PnoLint \
-PbuildJdkVersion=${{ env.BUILD_JDK_VERSION }} \
Expand All @@ -115,7 +115,7 @@ jobs:
- name: Build with Gradle
run: |
./gradlew --no-daemon --stacktrace build \
${{ startsWith(matrix.on, 'ubicloud') && '--max-workers=8' || '--max-workers=2' }} --parallel \
${{ startsWith(matrix.on, 'ubicloud') && '--max-workers=12' || '--max-workers=2' }} --parallel \
${{ matrix.coverage && '-Pcoverage' || '' }} \
${{ matrix.leak && '-Pleak' || '' }} \
${{ matrix.blockhound && '-Pblockhound' || '' }} \
Expand Down Expand Up @@ -236,7 +236,7 @@ jobs:

- name: Run the linters
run: |
./gradlew --no-daemon --stacktrace --max-workers=8 --parallel lint
./gradlew --no-daemon --stacktrace --max-workers=4 --parallel lint

site:
if: github.repository == 'line/armeria'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
publish:
name: Publish final artifacts
if: github.repository == 'line/armeria'
runs-on: ubicloud-standard-8
runs-on: ubicloud-standard-16
steps:
- uses: actions/checkout@v4

Expand All @@ -29,7 +29,7 @@ jobs:

- name: Build with Gradle
run: |
./gradlew --no-daemon --stacktrace --max-workers=8 --parallel -PflakyTests=false \
./gradlew --no-daemon --stacktrace --max-workers=12 --parallel -PflakyTests=false \
-Pretry=true -PfailOnPassedAfterRetry=false \
build
shell: bash
Expand Down
Loading