-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for preprocessors #6051
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new interface looks promising. 👍 👍 👍
I also understand that the decorator chain is mutable so that different decorators can be added in the preprocessor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍
|
||
## Implementing `HttpPreprocessor` and `RpcPreprocessor` | ||
|
||
<type://HttpPreprocessor> and <type://RpcPreprocessor> expose a <type://PartialClientRequestContext>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand what Partial
means, but it might be ambiguous for normal users.
What do you think of prefixing Pre
to imply it is used in *Preprocessor
?
<type://HttpPreprocessor> and <type://RpcPreprocessor> expose a <type://PartialClientRequestContext>. | |
<type://HttpPreprocessor> and <type://RpcPreprocessor> expose a <type://PreClientRequestContext>. |
+-----------+ +-----------------+ +-----------------+ +-----------------+ +----------+ +-----------+ | ||
``` | ||
|
||
Note that unlike decorators, <typeplural://HttpPreprocessor> are not executed for RPC-based clients. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Notes