Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Preview generation as a separate node instance #728

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

✨ Preview generation as a separate node instance #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d346d51
⬆️Upgrade dependencies(security + node.js version)
shepilov Nov 6, 2024
74b6049
♻️Removed unused docker files
shepilov Nov 6, 2024
fb00acb
✨Preview generation as a separate node instance
shepilov Nov 6, 2024
1e494c3
♻️Removed unused docker files + docker compose file with all dependen…
shepilov Nov 20, 2024
2b2b64a
♻️Added antivirus after rebasing refactoring to main
shepilov Nov 20, 2024
7022cb7
fix: on create skip folder for av scan
MontaGhanmy Nov 20, 2024
679d3a5
ref: feedback
MontaGhanmy Nov 20, 2024
f359df0
🐛 Fix config retrieval and type handling (#739)
MontaGhanmy Nov 22, 2024
49ec7b5
♻️Moved default services list to util function
shepilov Dec 3, 2024
66cb1db
🩹Added av as dependency to node service for antivirus tests
shepilov Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ jobs:
- name: Prettier code style check
run: |
cd tdrive
docker compose -f docker-compose.tests.yml run -e NODE_OPTIONS=--unhandled-rejections=warn node npm run lint:prettier
docker compose -f docker-compose.dev.deps.yml -f docker-compose.tests.yml run -e NODE_OPTIONS=--unhandled-rejections=warn node npm run lint:prettier
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this is the opportunity to update the instructions in the README.md

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm, you are talking about the main readme file or some page in the documentation?
if main readme, I didn't get how it is connected

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the main /README.md, the instructions to start drive are outdated there, and we're changing them here... Had a couple of potential contributors get stuck on this

- name: Lint
run: |
cd tdrive
docker compose -f docker-compose.tests.yml run -e NODE_OPTIONS=--unhandled-rejections=warn node npm run lint
docker compose -f docker-compose.dev.deps.yml -f docker-compose.tests.yml run -e NODE_OPTIONS=--unhandled-rejections=warn node npm run lint

test-backend:
runs-on: ubuntu-latest
Expand All @@ -62,16 +62,16 @@ jobs:
- name: e2e-mongo-s3-test
run: |
cd tdrive
docker compose -f docker-compose.tests.yml run --rm -e NODE_OPTIONS=--unhandled-rejections=warn node npm run test:all
docker compose -f docker-compose.tests.yml down
docker compose -f docker-compose.dev.deps.yml -f docker-compose.tests.yml run --rm -e NODE_OPTIONS=--unhandled-rejections=warn node npm run test:all
docker compose -f docker-compose.dev.deps.yml -f docker-compose.tests.yml down
- name: e2e-opensearch-test
run: |
cd tdrive
docker compose -f docker-compose.dev.tests.opensearch.yml up -d --force-recreate opensearch-node1 postgres node av
docker compose -f docker-compose.dev.deps.yml -f docker-compose.dev.tests.opensearch.yml up -d --force-recreate opensearch-node1 postgres node av
sleep 60
docker compose -f docker-compose.dev.tests.opensearch.yml logs
docker compose -f docker-compose.dev.tests.opensearch.yml run -e NODE_OPTIONS=--unhandled-rejections=warn -e SEARCH_DRIVER=opensearch -e DB_DRIVER=postgres -e PUBSUB_TYPE=local node npm run test:all
docker compose -f docker-compose.dev.tests.opensearch.yml down
docker compose -f docker-compose.dev.deps.yml -f docker-compose.dev.tests.opensearch.yml logs
docker compose -f docker-compose.dev.deps.yml -f docker-compose.dev.tests.opensearch.yml run -e NODE_OPTIONS=--unhandled-rejections=warn -e SEARCH_DRIVER=opensearch -e DB_DRIVER=postgres -e PUBSUB_TYPE=local node npm run test:all
docker compose -f docker-compose.dev.deps.yml -f docker-compose.dev.tests.opensearch.yml down

build-frontend:
runs-on: ubuntu-latest
Expand Down
5 changes: 5 additions & 0 deletions tdrive/backend/node/config/custom-environment-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
},
"webserver": {
"host": "TWAKE_DRIVE_HOST",
"port": "TWAKE_DRIVE_PORT",
shepilov marked this conversation as resolved.
Show resolved Hide resolved
"logger": {
"level": "LOG_LEVEL"
},
Expand Down Expand Up @@ -144,5 +145,9 @@
"debugMode": "AV_DEBUG_MODE",
"timeout": "AV_TIMEOUT",
"maxFileSize": "AV_MAX_FILE_SIZE"
},
"services": {
"__name": "SERVICES_LIST",
"__format": "json"
}
}
Loading
Loading