Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 front: don't flash password prompt when opening a shared link without password protection #511

Merged

Conversation

ericlinagora
Copy link
Contributor

Fix for ticket #315

@MontaGhanmy MontaGhanmy self-requested a review May 6, 2024 08:48
Copy link
Collaborator

@MontaGhanmy MontaGhanmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current change the public link only worked for authenticated users. Else, the user is shown an error/gets redirected to login page.

@ericlinagora ericlinagora force-pushed the 315-password-dialog-flash-on-unprotected-public-links branch from 7c15b2a to bf505a5 Compare May 7, 2024 12:39
@ericlinagora ericlinagora requested a review from MontaGhanmy May 7, 2024 13:15
@ericlinagora ericlinagora merged commit 14ecf20 into main May 11, 2024
7 checks passed
@ericlinagora ericlinagora deleted the 315-password-dialog-flash-on-unprotected-public-links branch May 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants