Reduce docker image from 1.39 GB to 611 MB #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guimard
force-pushed
the
optimize-docker
branch
from
9560366 to
d418844
Compare
guimard
commented
Jan 23, 2024
| @@ -13,10 +13,12 @@ RUN apt update -y | |||
|
|
|||
| RUN apt install --assume-yes nextcloud-desktop-cmd | |||
|
|
|||
| RUN apt install ldap-utils | |||
| RUN apt install -y ldap-utils | |||
There was a problem hiding this comment.
Was missing, this break build when updates are available
guimard
commented
Jan 23, 2024
|
|
||
| RUN apt update && apt -y dist-upgrade | ||
| RUN apt install dirmngr | ||
| RUN apt install -y gnupg |
There was a problem hiding this comment.
The dirmngr should be replaced by gnupg: enough here and lighter
guimard
commented
Jan 23, 2024
| CMD ["npm", "run", "start"] | ||
| #CMD ["npm", "run", "start"] | ||
|
|
||
| FROM updated |
There was a problem hiding this comment.
no need to copy the environment, since we're using @rollup/plugin-node-resolve, nothing is useful except the generated JS itself
guimard
commented
Jan 23, 2024
| COPY --from=1 /usr/src/app/dist/* / | ||
| RUN mv express_server.js express_server.mjs | ||
|
|
||
| CMD ["node","express_server.mjs"] |
There was a problem hiding this comment.
no need to have npm to run a single command
There was a problem hiding this comment.
I'll test one more time with modules, due to a problem we had yesterday with compiling ts and creating a bundle with a rollup
and thank you, Xavier!)
chibenwa
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to reduce size