🐛Throw write exception with proper storage identifier

linagora · Dec 19, 2024 · 0025964 · 0025964
1 parent 93750c5
commit 0025964
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/tdrive/backend/node/src/core/platform/services/storage/oneof-storage-strategy.ts b/tdrive/backend/node/src/core/platform/services/storage/oneof-storage-strategy.ts
@@ -70,18 +70,21 @@ export class OneOfStorageStrategy implements StorageConnectorAPI {
     );
 
     // Log all errors and throw if all write operations fail
-    const errors = writeResults.filter(result => result.status === "rejected");
-    errors.forEach((error, index) => {
-      const storageId = this.storages[index].getId();
-      logger.error(
-        new OneOfStorageWriteOneFailedException(
-          storageId,
-          `Error writing to storage ${storageId}`,
-          (error as PromiseRejectedResult).reason,
-        ),
-      );
+    let errorsCount = 0;
+    writeResults.forEach((result, index) => {
+      if (result.status === "rejected") {
+        const storageId = this.storages[index].getId();
+        logger.error(
+          new OneOfStorageWriteOneFailedException(
+            storageId,
+            `Error writing to storage ${storageId}`,
+            (result as PromiseRejectedResult).reason,
+          ),
+        );
+        errorsCount++;
+      }
     });
-    if (errors.length === this.storages.length) {
+    if (errorsCount === this.storages.length) {
       throw new WriteFileException(`Write ${path} failed for all storages`);
     }