Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-3265 Fix double scrolling composer #3280

Merged
merged 1 commit into from
Nov 27, 2024
Merged

TF-3265 Fix double scrolling composer #3280

merged 1 commit into from
Nov 27, 2024

Conversation

tddang-linagora
Copy link
Contributor

Issue

Dependency

Resolved

Screen.Recording.2024-11-18.at.16.04.51.mov

@tddang-linagora tddang-linagora self-assigned this Nov 18, 2024
@dab246
Copy link
Member

dab246 commented Nov 18, 2024 •
edited by tddang-linagora
Loading

  • We should test it on Linux or Windows machine because on Mac currently no such error occurs

@tddang-linagora
Copy link
Contributor Author

We should test it on Linux or Windows machine because on Mac currently no such error occurs

This is recorded on MacOS

Screen.Recording.2024-11-19.at.10.14.32.mov

@dab246
Copy link
Member

dab246 commented Nov 19, 2024

We should test it on Linux or Windows machine because on Mac currently no such error occurs

This is recorded on MacOS

Screen.Recording.2024-11-19.at.10.14.32.mov

Is this recorde test on Firefox browser? So, Please add demo after fix with this browser.

@tddang-linagora
Copy link
Contributor Author

Please add demo after fix with this browser.

Screen.Recording.2024-11-19.at.13.50.43.mov

dab246
dab246 previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dab246
Copy link
Member

dab246 commented Nov 20, 2024 •
edited by tddang-linagora
Loading

  • Double scrollbar is gone but cursor disappears when entering a new line
error.mov

On prod: tmail.linagora.com it still work well:

Screen.Recording.2024-11-20.at.10.34.09.mov

dab246
dab246 previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check build failed on CI

hoangdat
hoangdat reviewed Nov 25, 2024
View reviewed changes
pubspec.yaml Outdated Show resolved Hide resolved
dab246
dab246 reviewed Nov 26, 2024
View reviewed changes
contact/pubspec.lock Outdated Show resolved Hide resolved
dab246
dab246 approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment •
edited by tddang-linagora
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Squash commit & rebase

@tddang-linagora tddang-linagora force-pushed the fixbug/TF-3265-double-scrolling-composer branch from 4400ed3 to defb16e Compare November 26, 2024 03:21
@hoangdat hoangdat merged commit 1a58542 into master Nov 27, 2024
21 checks passed
@dab246 dab246 mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 dab246 approved these changes

Assignees

@tddang-linagora tddang-linagora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tddang-linagora @dab246 @hoangdat