Refactor/splitting libraries #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we want to use shared libs in nx, you cannot set `paths` in tsconfig or it will confuse the tsc so it won't locate your shared library. In order to use shared libs in the future, I deleted the `paths` in recnet's tsconfig.json and update the import paths.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
joannechen1223
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add three shared libs.
recnet-date-fns: RecNet's library for Date-related functions.recnet-api-model: RecNet's api data model. Apps can use these schemas to validate incoming request or response and enjoy the type-safety API developing experience.recnet-jwt: Define JWT schema for our app. Use this for verifying JWT atapiand issue at web app.They are not perfect now since our migration haven't finished. Feel free to modify these libraries while developing.
Related Issue
N/A
Notes
To follow the best practice of Nx, most of the logic should be put under
/libs. Decomposing into shared libraries has the following benefits:Read more:
Testing link: https://rec-oz16z3yxb-recnet-542617e7.vercel.app/
TODO